Skip to content

Conversation

@wieslawsoltes
Copy link
Owner

Summary

  • add a search box above the sample pages tab list
  • filter tab items as the user types and show a message when nothing matches

Testing

  • dotnet test AvaloniaBehaviors.sln --no-build (fails: dotnet not found)

@pull-request-size pull-request-size bot added size/L and removed size/S labels May 20, 2025
@wieslawsoltes wieslawsoltes requested a review from Copilot May 20, 2025 20:18
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds a search filter to the sample pages by introducing a search box above the tab list and dynamically filtering the tabs based on input.

  • Added a SearchBox and a NoMatchesText control to MainView.axaml.
  • Created an OnSearchTextChanged event handler in MainView.axaml.cs to filter tab items and display a message when no match is found.

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
samples/BehaviorsTestApplication/Views/MainView.axaml.cs Introduced OnSearchTextChanged that implements dynamic tab filtering logic.
samples/BehaviorsTestApplication/Views/MainView.axaml Modified the layout to include a search box and a message for no matches, wrapping the TabControl within a DockPanel.
Comments suppressed due to low confidence (1)

samples/BehaviorsTestApplication/Views/MainView.axaml.cs:13

  • The removal of the AvaloniaXamlLoader.Load(this) call (previously in InitializeComponent) may result in UI components not being properly loaded. Verify that the view initialization occurs as expected elsewhere or reinstate the call in the constructor.
private void OnSearchTextChanged(object? sender, Avalonia.Interactivity.RoutedEventArgs e)

@wieslawsoltes wieslawsoltes merged commit ca3dce4 into master May 20, 2025
13 checks passed
@wieslawsoltes wieslawsoltes deleted the codex/implement-search-functionality-for-sample-pages branch May 20, 2025 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants